feat: Add deprecation warning for Vision API by mallpunk · Pull Request #2469 · cognitedata/cognite-sdk-python

mallpunk · 2026-02-13T09:25:51Z

Added deprecation warning for Vision API.

Ref https://docs.cognite.com/cdf/deprecated#deprecated-and-retired-features

…eady.

gemini-code-assist · 2026-02-13T09:25:55Z

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

codecov · 2026-02-13T09:36:34Z

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.86%. Comparing base (e2f06c0) to head (c9b4f9b).
⚠️ Report is 11 commits behind head on master.

Files with missing lines	Patch %	Lines
cognite/client/_api/vision.py	60.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2469   +/-   ##
=======================================
  Coverage   48.86%   48.86%           
=======================================
  Files         191      191           
  Lines       26152    26161    +9     
=======================================
+ Hits        12778    12783    +5     
- Misses      13374    13378    +4

Files with missing lines	Coverage Δ
cognite/client/_api/vision.py	`56.09% <60.00%> (+0.54%)`	⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mallpunk · 2026-02-18T08:52:17Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a deprecation warning for the Vision API. The changes are well-structured, including updates to the code to raise a warning, modifications to the documentation to reflect the deprecation, and new tests to verify the warning is emitted correctly. I have a few suggestions to align the code with the style guide and improve the implementation of the warning.

cognite/client/_api/vision.py

tests/tests_unit/test_api/test_vision_extract.py

…d UserWarning with FutureWarning

gemini-code-assist · 2026-02-18T09:52:53Z

Summary of Changes

Hello @mallpunk, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a deprecation warning for the Vision API across the SDK and its associated documentation. The primary goal is to proactively inform users about the API's planned removal in a future version, guiding them towards recommended alternatives and ensuring a smooth transition for any existing integrations.

Highlights

Deprecation Warning Implementation: A new static method _deprecation_warning was added to the VisionAPI class to issue a FutureWarning regarding the Vision API's upcoming removal. This warning is now triggered when calling the extract and get_extract_job methods.
Documentation Updates: The documentation was updated to reflect the deprecation. A warning block was added to the contextualization.rst file, and the extract and get_extract_job methods of the Vision API were explicitly listed as deprecated in deprecated.rst.
Testing for Deprecation: New unit tests were introduced to verify that the FutureWarning is correctly emitted when the deprecated extract and get_extract_job methods are invoked. Additionally, pytest.ini was updated to ignore FutureWarning from the cognite.client module during tests.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

cognite/client/_api/vision.py
- Added a static method _deprecation_warning to issue a FutureWarning.
- Integrated the _deprecation_warning call into the extract and get_extract_job methods.
docs/source/contextualization.rst
- Added a reStructuredText warning directive to the Vision API section, notifying users of its deprecation.
docs/source/deprecated.rst
- Included the Vision API's extract and get_extract_job methods in the deprecated features documentation.
pytest.ini
- Configured pytest to ignore FutureWarning originating from the cognite.client module.
tests/tests_unit/test_api/test_vision_extract.py
- Added new test cases test_extract_emits_deprecation_warning and test_get_extract_job_emits_deprecation_warning to assert FutureWarning is raised.
- Refactored variable VAPI to vision_api for improved readability and consistency.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request effectively adds a deprecation warning for the Vision API, which is a necessary step for API lifecycle management. The changes include adding FutureWarning to the relevant API methods, updating the documentation to reflect the deprecation, and adding tests to ensure the warnings are correctly triggered. The implementation is solid. I have one suggestion to improve the developer experience by adjusting the stacklevel of the warning to point directly to the user's code.

cognite/client/_api/vision.py

haakonvt

LGTM, one suggestion

haakonvt · 2026-02-18T12:35:27Z

docs/source/contextualization.rst

 Vision
 ------

+.. warning::


Maybe we could also do something like this to really make it stand out?

Vision (deprecated) -------------------

haakonvt

Great!

einarmo · 2026-02-19T13:07:08Z

🦄

Draft deprecation warning for Vision API. Link will be updated when r…

be1f34f

…eady.

Formatting

10e5f7d

mallpunk changed the title ~~DRAFT deprecation warning for Vision API~~ feat: DRAFT deprecation warning for Vision API Feb 13, 2026

mallpunk added 4 commits February 13, 2026 13:39

Added tests

899c792

Making Ruff happy

0a9efc6

Added link to deprecation notice

21218f2

Added deprecation warning to documentation and fixed indexing warning

39b9a75

gemini-code-assist bot reviewed Feb 18, 2026

View reviewed changes

cognite/client/_api/vision.py Show resolved Hide resolved

tests/tests_unit/test_api/test_vision_extract.py Outdated Show resolved Hide resolved

tests/tests_unit/test_api/test_vision_extract.py Outdated Show resolved Hide resolved

Changed line length and variable naming to match style guide, replace…

7b520d6

…d UserWarning with FutureWarning

mallpunk changed the title ~~feat: DRAFT deprecation warning for Vision API~~ feat: Add deprecation warning for Vision API Feb 18, 2026

mallpunk marked this pull request as ready for review February 18, 2026 09:52

mallpunk requested review from a team as code owners February 18, 2026 09:52

gemini-code-assist bot reviewed Feb 18, 2026

View reviewed changes

cognite/client/_api/vision.py Show resolved Hide resolved

Updated stacklevel for better developer experience

6fb1f59

haakonvt reviewed Feb 18, 2026

View reviewed changes

cognite/client/_api/vision.py Outdated Show resolved Hide resolved

Changing FutureWarning to UserWarning for increased visibility

1f4c9a4

haakonvt previously approved these changes Feb 18, 2026

View reviewed changes

Added deprecation warning to doc title for extra extra visibility

c9b4f9b

mallpunk dismissed haakonvt’s stale review via c9b4f9b February 18, 2026 12:40

haakonvt approved these changes Feb 18, 2026

View reviewed changes

haakonvt added the waiting-for-risk-review Waiting for a member of the risk review team to take an action label Feb 18, 2026

einarmo self-assigned this Feb 19, 2026

einarmo added the risk-review-ongoing Risk review is in progress label Feb 19, 2026

einarmo removed the waiting-for-risk-review Waiting for a member of the risk review team to take an action label Feb 19, 2026

einarmo added the waiting-for-team Waiting for the submitter or reviewer of the PR to take an action label Feb 19, 2026

mallpunk added this pull request to the merge queue Feb 20, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 20, 2026

mallpunk added this pull request to the merge queue Feb 20, 2026

Merged via the queue into master with commit ea1b662 Feb 20, 2026
18 checks passed

mallpunk deleted the mallpunk/vision-deprecation-warning branch February 20, 2026 08:05

erlendvollset mentioned this pull request Feb 20, 2026

chore(master): release cognite-sdk-python 7.93.0 #2482

Open

Comments

Conversation

mallpunk commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Feb 13, 2026

Uh oh!

codecov bot commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mallpunk commented Feb 18, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot commented Feb 18, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

haakonvt left a comment

Choose a reason for hiding this comment

Uh oh!

haakonvt Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

haakonvt left a comment

Choose a reason for hiding this comment

Uh oh!

einarmo commented Feb 19, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mallpunk commented Feb 13, 2026 •

edited

Loading

codecov bot commented Feb 13, 2026 •

edited

Loading